Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R-CMD-CHECK fails due to incomplete documentation #23

Closed
GegznaV opened this issue Jun 9, 2020 · 4 comments
Closed

R-CMD-CHECK fails due to incomplete documentation #23

GegznaV opened this issue Jun 9, 2020 · 4 comments
Assignees
@eoduniyi

Comments

@GegznaV
Copy link
Member

GegznaV commented Jun 9, 2020

https://github.com/r-hyperspec/hySpc.dplyr/runs/753435891?check_suite_focus=true

image
@cbeleites
Copy link
Collaborator

@eoduniyi, @GegznaV marked some missing documentation with FIXME - can you please take care of this?

I think this can safely be done in the develop branch.

@eoduniyi
Copy link
Contributor

Fixed the documentation issue going to close now.

@GegznaV
Copy link
Member Author

GegznaV commented Jun 13, 2020

@eoduniyi it would be better if each closed issue would be linked to a pull request/commit that closes the issue.
Do you know "magical" words 'closes', 'fixes', 'solves' etc. in pull requests that automatically close issues?

@eoduniyi
Copy link
Contributor

@eoduniyi it would be better if each closed issue would be linked to a pull request/commit that closes the issue.
Do you know "magical" words 'closes', 'fixes', 'solves' etc. in pull requests that automatically close issues?

@GegznaV Thank you will apply from here on out!

@GegznaV GegznaV mentioned this issue Jun 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eoduniyi eoduniyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cbeleites @GegznaV @eoduniyi