Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate data package (hySpc.chondro) for chondro #1

Closed
12 tasks done
eoduniyi opened this issue Aug 2, 2020 · 10 comments
Closed
12 tasks done

Create separate data package (hySpc.chondro) for chondro #1

eoduniyi opened this issue Aug 2, 2020 · 10 comments
Assignees

Comments

@eoduniyi
Copy link
Contributor

eoduniyi commented Aug 2, 2020

I'm on my way to properly create hySpc.chondro package.

  • Create repo r-hyperspec/hySpc.chondro.
  • Copy *chondro related functions from cbeleites/hyperSpec to r-hyperspec/hySpc.chondro.
  • Review and update the documentation.
  • Add unit tests:
    • Several simple tests were added.
  • Update vignette:
    • The vignette was minimally updated. A more comprehensive update could be performed after the package is created.
  • Fix issues to make r-hyperspec/hySpc.chondro to pass R-CMD-check.
  • Create pkgdown website:
  • Update the main webpage (https://r-hyperspec.github.io/) with the link to this repo.
  • Copy the newest labels (tags) from repo cbeleites/hyperSpec:
  • License the package correctly:
  • Assign the authors and contributors correctly
  • Properly deprecate appropriate functions in cbeleites/hyperSpec:
@GegznaV
Copy link
Member

GegznaV commented Aug 3, 2020

About the pkgdown website, it is already created:

image

So, @eoduniyi, please:

  1. Enable Git Pages for gh-pages branch,
  2. Add URL in the description of this repo. THe URL should be https://r-hyperspec.github.io/hySpc.chondro/ (similarly to Enable Git Pages cbeleites/hyperSpec#158)

@eoduniyi
Copy link
Contributor Author

eoduniyi commented Aug 3, 2020

Done!

@GegznaV
Copy link
Member

GegznaV commented Aug 3, 2020

image

I did that last week while reviewing other r-hyperspec repos. Please, check the website.


@eoduniyi, please, grant me (and all @r-hyperspec/r-hyperspec team) write access to this repo.

@GegznaV
Copy link
Member

GegznaV commented Aug 3, 2020

This part works, thanks 👍

image

@eoduniyi
Copy link
Contributor Author

eoduniyi commented Aug 3, 2020

image

I did that last week while reviewing other r-hyperspec repos. Please, check the website.

@eoduniyi, please, grant me (and all @r-hyperspec/r-hyperspec team) write access to this repo.

Will try my best!

@eoduniyi
Copy link
Contributor Author

eoduniyi commented Aug 3, 2020

image
I did that last week while reviewing other r-hyperspec repos. Please, check the website.
@eoduniyi, please, grant me (and all @r-hyperspec/r-hyperspec team) write access to this repo.

Will try my best!

@GegznaV do you have write access now?

@GegznaV
Copy link
Member

GegznaV commented Aug 3, 2020

@GegznaV do you have write access now?

Yes, I have. Thank you, @eoduniyi

@eoduniyi
Copy link
Contributor Author

eoduniyi commented Aug 3, 2020

image
I did that last week while reviewing other r-hyperspec repos. Please, check the website.
@eoduniyi, please, grant me (and all @r-hyperspec/r-hyperspec team) write access to this repo.

Will try my best!

@GegznaV do you have write access now?

Yessssss

@GegznaV
Copy link
Member

GegznaV commented Aug 3, 2020

Properly deprecate appropriate functions in cbeleites/hyperSpec:

@eoduniyi, I will do this, OK

@GegznaV GegznaV changed the title Create seperate data package (hySpc.chondro) for chondro Create separate data package (hySpc.chondro) for chondro Aug 5, 2020
@GegznaV
Copy link
Member

GegznaV commented Aug 5, 2020

I think the package is created. Now we can polish it.

@GegznaV GegznaV closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants