From 2ad2d18c57a8a9a5cfb72ada2771e6c05f0cf76b Mon Sep 17 00:00:00 2001 From: Michael Chirico Date: Sun, 18 Feb 2024 01:06:31 -0800 Subject: [PATCH] Mention possibility of svn add, correct typo --- 07-lifecycle_of_a_Patch.Rmd | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/07-lifecycle_of_a_Patch.Rmd b/07-lifecycle_of_a_Patch.Rmd index e526429..3eefa6e 100644 --- a/07-lifecycle_of_a_Patch.Rmd +++ b/07-lifecycle_of_a_Patch.Rmd @@ -42,13 +42,15 @@ Then you should check that R still works as expected via: If there is no test for your proposed change you can add a new regression test, following [the guidelines](#TestR). -Then you should bring changes from the repository into the working copy, in case any other change has been introduced, and create a path.diff file with just the changes you want to propose to the R core: +Then you should bring changes from the repository into the working copy, in case any other change has been introduced, and create a patch.diff file with just the changes you want to propose to the R core: ```sh svn update svn diff > patch.diff ``` +Most often, changes are made to existing files, but if you happen to be adding a new file in your change, you'll need to run `svn add path/to/file1 ...` before running `svn diff` to mark those files for inclusion. + This `patch.diff` file is the one that can be proposed to the R core via [Bugzilla](#SubmitPatches). You can also [ask for reviews](#PatchesReview) to the patch before proposing it to the R core via the [r-devel mailing list](https://stat.ethz.ch/mailman/listinfo/r-devel) or the slack channel of the R-contributors space. ### Using a git mirror