Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to retrieve ROI names in a case insensitive way #44

Open
raffaelespinoni opened this issue Feb 4, 2022 · 2 comments · May be fixed by #47
Open

add ability to retrieve ROI names in a case insensitive way #44

raffaelespinoni opened this issue Feb 4, 2022 · 2 comments · May be fixed by #47

Comments

@raffaelespinoni
Copy link

raffaelespinoni commented Feb 4, 2022 •
edited
Loading

HI,
i'm experiencing problem with low quality ROI labels (written like this: Heart, heart, HEART),
maybe an option to extract case insensitive ROIs could be useful to other also

I have a quick_fix in rtstruct.py:98
if structure_roi.ROIName.casefold() == name.casefold():

maybe a more general option while using ".get_roi__mask_by_name" could be better
@asim-shrestha
Copy link
Contributor

Hi @raffaelespinoni, I'm thinking we add an option in get roi_mask_by_name to enable case insensitivity using the code you've provided. I'll try to get this done for this wednesday but feel free to submit your own pull request if you'd like :)

@raffaelespinoni
Copy link
Author

Thank's, i'm opening a PR

@raffaelespinoni raffaelespinoni linked a pull request Feb 22, 2022 that will close this issue
Open
@awtkns awtkns linked a pull request Feb 22, 2022 that will close this issue
add ability to retrieve ROI names in a case insensitive way #47
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add ability to retrieve ROI names in a case insensitive way SpinoniRaffaele/rt-utils
2 participants
@raffaelespinoni @asim-shrestha