Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeGetVolumeStats feature does not work with Kubernetes #34

Closed
tksm opened this issue Mar 22, 2021 · 0 comments · Fixed by #35
Closed

NodeGetVolumeStats feature does not work with Kubernetes #34

tksm opened this issue Mar 22, 2021 · 0 comments · Fixed by #35

Comments

@tksm
Copy link
Contributor

tksm commented Mar 22, 2021

Thank you for implementing NodeGetVolumeStats in quobyte-csi v1.5.1.
I immediately tried this feature with Kubernetes v1.19, but I could not get kubelet_volume_stats_* metrics by kubelet.

According to NodeGetVolumeStats section in CSI Spec v1.3.0, it seems that quobyte-csi needs to return GET_VOLUME_STAT node capability. kubelet also checks this capability whether the driver support VolumeStats or not.

I confirmed that adding GET_VOLUME_STATS capability to NodeGetCapabilities() would fix this problem.

diff --git a/driver/node.go b/driver/node.go
index ad571ac..4737736 100644
--- a/driver/node.go
+++ b/driver/node.go
@@ -166,7 +166,7 @@ func (d *QuobyteDriver) NodeGetCapabilities(ctx context.Context, req *csi.NodeGe
                        {
                                Type: &csi.NodeServiceCapability_Rpc{
                                        Rpc: &csi.NodeServiceCapability_RPC{
-                                               Type: csi.NodeServiceCapability_RPC_UNKNOWN,
+                                               Type: csi.NodeServiceCapability_RPC_GET_VOLUME_STATS,
                                        },
                                },
                        },
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant