Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Merge into Base #6

Closed
quinnj opened this issue Jun 16, 2014 · 4 comments
Closed

Merge into Base #6

quinnj opened this issue Jun 16, 2014 · 4 comments

Comments

@quinnj
Copy link
Owner

quinnj commented Jun 16, 2014

It's been long-discussed to merge this refactored code into Base, but my make-fu is quite poor and I'm not entirely sure how we want to go about it.
@StefanKarpinski, last we talked, it sounded like you had a good idea how to do the merge. I'm not sure if we would do a submodule a la libuv, with the code still residing in this repo (or JuliaLang/Dates.jl), or if we just want to haul all the code over. There's also the question of where it should live. Is base/dates/ good enough? Do we want to carve out a process for future non-core stdlib packages with something else?

@StefanKarpinski
Copy link

I think it should just be moved into the main Julia repo – or at least some of it should. Submodules are a constant pain and this is going to be fairly strongly integrated – some functions in Base ought to return date/time objects.

@quinnj
Copy link
Owner Author

quinnj commented Jun 16, 2014

Should I make a PR immediately, or should we code review what's here first?

@StefanKarpinski
Copy link

Go for the PR. Follow the Pkg model / various other things that have their own modules in Base.

@IainNZ
Copy link

IainNZ commented Aug 20, 2014

Close?

@quinnj quinnj closed this as completed Aug 20, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants