Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading is prone to spurious driver wakeups #984

Closed
Ralith opened this issue Jan 25, 2021 · 2 comments
Closed

Reading is prone to spurious driver wakeups #984

Ralith opened this issue Jan 25, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Ralith
Copy link
Collaborator

Ralith commented Jan 25, 2021

quinn::RecvStream::poll_read_generic currently wakes the connection driver on every successful operation in case we need to transmit flow control credit. As of #880 and #894 we no longer issue credit after every read, so we can reduce CPU load by only waking the connection driver if flow control actually does need to be issued.
@Ralith Ralith added enhancement New feature or request good first issue Good for newcomers labels Jan 25, 2021
@djc djc mentioned this issue Jan 25, 2021
Closed
@geieredgar geieredgar mentioned this issue Jan 26, 2021
Closed
@geieredgar
Copy link
Contributor

Now that #992 has landed in main via #991, we could close this issue.

@djc
Copy link
Member

djc commented Jan 30, 2021

Yup!

@djc djc closed this as completed Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ralith @djc @geieredgar