Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of user / password login? #41

Open
poblish opened this issue Sep 7, 2023 · 2 comments
Open

Example of user / password login? #41

poblish opened this issue Sep 7, 2023 · 2 comments
Assignees
Labels
Feature Major improvement request

Comments

@poblish
Copy link

poblish commented Sep 7, 2023

Is there a Golang example of using user and password? Git history suggests there used to be, but it was removed at some point.

We've been using this happily with v.0.6.0, but in v0.7.0 it has no effect and login never occurs (no error). Our previously working code:

func (e *client) ToAdmin(message *quickfix.Message, sessionID quickfix.SessionID) {
	if msgType, err := message.Header.GetString(tag.MsgType); err == nil && msgType == "A" {
		message.Body.SetBool(tag.ResetSeqNumFlag, true)
		message.Body.SetField(tag.Username, quickfix.FIXString(e.username))
		message.Body.SetField(tag.Password, quickfix.FIXString(e.password))
	}
}

Other examples I can find on the 'net (old StackOverflow questions, QF Java docs etc.) suggest this ought to still work, but it would nice to be sure.

@poblish poblish added the Feature Major improvement request label Sep 7, 2023
@ackleymi
Copy link
Member

Git history suggests there used to be

Can you point me to the relevant history? I can't seem to find it

@poblish
Copy link
Author

poblish commented Oct 30, 2023

Git history suggests there used to be

Can you point me to the relevant history? I can't seem to find it

Yes, it's impossible to find via Git history. I think it was probably this message I originally had in mind, though reading it again I see that the commenter was suggesting new code to add to the existing template (now deleted). There's some more context here.

Either way, both of those are 6+ years old, so it would be great to have some guidance as to whether this is still the correct pattern to be using. That would at least narrow down my debugging task for trying to pick up the 0.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Major improvement request
Projects
None yet
Development

No branches or pull requests

2 participants