Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't pace when congestion limited #1983

Closed
wants to merge 1 commit into from

Conversation

marten-seemann
Copy link
Member

No description provided.

@marten-seemann marten-seemann force-pushed the dont-pace-when-congestion-limited branch from 1a272cb to 3fc4f3b Compare August 2, 2019 08:07
@codecov-io
Copy link

Codecov Report

Merging #1983 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1983      +/-   ##
==========================================
+ Coverage   85.34%   85.36%   +0.02%     
==========================================
  Files          99       99              
  Lines        7197     7188       -9     
==========================================
- Hits         6142     6136       -6     
+ Misses        768      767       -1     
+ Partials      287      285       -2
Impacted Files Coverage Δ
internal/congestion/cubic_sender.go 92.2% <100%> (+0.11%) ⬆️
internal/wire/version_negotiation.go 88.24% <0%> (-11.76%) ⬇️
internal/ackhandler/sent_packet_handler.go 74.4% <0%> (-0.92%) ⬇️
internal/wire/new_connection_id_frame.go 94.12% <0%> (-0.75%) ⬇️
internal/handshake/crypto_setup.go 67.05% <0%> (-0.37%) ⬇️
internal/ackhandler/received_packet_history.go 96.67% <0%> (-0.16%) ⬇️
server.go 84.62% <0%> (+0.1%) ⬆️
client.go 80.86% <0%> (+0.67%) ⬆️
internal/wire/extended_header.go 93.6% <0%> (+0.87%) ⬆️
internal/wire/header.go 89.55% <0%> (+1.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db645f3...3fc4f3b. Read the comment docs.

@marten-seemann
Copy link
Member Author

#2615 is the better solution for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants