-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[revealjs] Scroll View documentation #1387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cwickham here is a first draft.
Several questions:
-
I put it last after multiplex. Should we put it before or elsewhere ? Presenting part seems a good fit just not sure of the order.
-
One can see a demo at
https://prerelease.quarto.org/docs/presentations/revealjs/demo/?view=scroll. Should we add a screenshot ? Or an iframe to the link above ? Or a specific example built like our other small one to show how it looks like ?
🚀 Deployed on https://deploy-preview-1387.quarto.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Regarding your questions:
- This seems most related to navigation, so maybe it belongs closer to the top. Maybe after "Overview Mode"?
- Yes, I think it needs a live example that someone can scroll. Maybe an iframe is the easiest?
Two other places we might need changes:
- This section talks about swiping on mobile, which is now not the default interaction: https://quarto.org/docs/presentations/revealjs/advanced.html#touch-navigation
- I think scroll view and jump to slide should be called out as highlights in
docs/prerelease/1.6/_highlights.qmd
🚀 Deployed on https://deploy-preview-1387.quarto.org |
🚀 Deployed on https://deploy-preview-1387.quarto.org |
I am now understanding we are hitting problem and the freeze is not correctly updated to have this feature working in Quarto web; |
We need to wait for #1389 to be merged so that this feature is fully working |
🚀 Deployed on https://deploy-preview-1387.quarto.org |
Co-authored-by: Charlotte Wickham <charlotte.wickham@posit.co>
as commiting from github the review messes up the table.
This require a new meta to use as we want absolute here and not relative like [](/docs/...) gives us
6754f14
to
b5c0a3b
Compare
🚀 Deployed on https://deploy-preview-1387.quarto.org |
Regarding this, it seems tricky 🤔 It seems swipe is still activated for touch navigation, but now Horizontal and vertical swipe will do the same. I can add a paragraph about scroll mode maybe 🤔 But it could be unclear to explain. Do you have a proposal ? I tested https://prerelease.quarto.org/docs/presentations/revealjs/demo on mobile to check. |
/deploy-preview |
🚀 Deployed on https://deploy-preview-1387.quarto.org |
I guess it's the second sentence in this bit I find a bit misleading:
Because now there is no real distinction between vertical and horizontal swipes. So, maybe just deleting the second sentence is enough:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I see. Done. Thanks a lot for the review! |
This adds documentation for new feature integrated with Quarto
Add support for new Scroll View mode of Revealjs quarto-cli#11034
Add an example, or link to an example