quarto v1.5.55 fixed issue, but does not cleanup correctly

quarto-dev · Jul 19, 2024 · b2dcb91 · b2dcb91
1 parent faed9c0
commit b2dcb91
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -4,7 +4,7 @@
 
 - This package now uses the x.y.z.dev versionning scheme to indicate development, patch, minor and major versions. This follows [Tidyverse package version conventions](https://r-pkgs.org/lifecycle.html#sec-lifecycle-version-number-tidyverse).
 
-- Adapt tests for CRAN checks issues due to Quarto v1.5.54 regression, fixed in Quarto v1.5.55.
+- Adapt tests for CRAN checks issues due to Quarto v1.5.54 regression (though it is fixed upstream).
 
 - Approval check in `quarto_add_extension()` and `quarto_use_template()` now works correctly (thanks, @eveyp, #172).
 

diff --git a/tests/testthat/test-quarto.R b/tests/testthat/test-quarto.R
@@ -4,8 +4,8 @@ test_that("quarto_version returns a numeric version", {
 })
 
 test_that("quarto_run gives guidance in error", {
-  # we need to skip previous versions because 1.5.41 introduced an issue solved in 1.5.55
-  skip_if_quarto_between("1.5.41", "1.5.54")
+  # we need to skip previous versions because 1.5.41 introduced an issue solved completely in 1.5.56
+  skip_if_quarto_between("1.5.41", "1.5.55")
   local_reproducible_output(width = 1000)
   expect_snapshot(
     error = TRUE,