Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize the number of times engine detection happens #7722

Closed
cscheid opened this issue Nov 27, 2023 · 1 comment
Closed

Minimize the number of times engine detection happens #7722

cscheid opened this issue Nov 27, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cscheid
Copy link
Collaborator

cscheid commented Nov 27, 2023

See #7696 (comment)

JJ's first attempt broke includes. Let's try to fix this.

@cscheid cscheid self-assigned this Nov 27, 2023
@cscheid cscheid added this to the v1.5 milestone Nov 30, 2023
@cscheid cscheid added the enhancement New feature or request label Nov 30, 2023
@cscheid
Copy link
Collaborator Author

cscheid commented Feb 26, 2024

This is now fixed on main, and engine detection is cached.

@cscheid cscheid closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant