Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Edge not detected (Quarto 1.6.4) #10464

Closed
Steinthal opened this issue Aug 5, 2024 · 11 comments · Fixed by #10574
Closed

Microsoft Edge not detected (Quarto 1.6.4) #10464

Steinthal opened this issue Aug 5, 2024 · 11 comments · Fixed by #10574
Assignees
Labels
bug Something isn't working chromium puppeteer Issues with puppeteer and remote chromium rendering
Milestone

Comments

@Steinthal
Copy link

Bug description

I've removed chromium from my MacBook (and Mac Mini). After a restart, Quarto 1.6.4 complains that no chromium was detected and does not use Microsoft Edge which is installed. Reference: #10172

Steps to reproduce

Take the example from the original post (#10162):

---
title: "In-Class: Relations - Digraphs"
format: 
  pdf: default
---

Any quarto document that includes a diagram and compiling a PDF; here's a sample:


```{dot}
//| fig-width: 2
digraph {
  node [shape = circle, width=0.5];
  rankdir = LR;
  1 -> 1;
  1 -> 2;
  2 -> 4; 
  1 -> 3;
  3 -> 4;
  4 -> 1;
}

```

Expected behavior

Edge should be used if chromium is not installed

Actual behavior

Error message:

ERROR: Chrome not found

No Chrome or Chromium installation was detected.

Please run 'quarto install chromium' to install Chromium.

Your environment

  • IDE: n/a
  • macOS: 14.6 (23G80) as well as 15.1 Beta (24B5009l)

Quarto check output

Quarto 1.6.4
[✓] Checking versions of quarto binary dependencies...
      Pandoc version 3.2.0: OK
      Dart Sass version 1.70.0: OK
      Deno version 1.41.0: OK
      Typst version 0.11.0: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
      Version: 1.6.4
      Path: /Applications/quarto/bin

[✓] Checking tools....................OK
      TinyTeX: (not installed)
      Chromium: (not installed)

[✓] Checking LaTeX....................OK
      Using: Installation From Path
      Path: /Library/TeX/texbin
      Version: 2024

[✓] Checking basic markdown render....OK

[✓] Checking Python 3 installation....OK
      Version: 3.10.2
      Path: /Users/USER/.pyenv/versions/3.10.2/bin/python3
      Jupyter: 5.3.1
      Kernels: python3

[✓] Checking Jupyter engine render....OK

[✓] Checking R installation...........OK
      Version: 4.4.1
      Path: /Library/Frameworks/R.framework/Resources
      LibPaths:
        - /Library/Frameworks/R.framework/Versions/4.4-arm64/Resources/library
      knitr: 1.48
      rmarkdown: 2.27

[✓] Checking Knitr engine render......OK
@Steinthal Steinthal added the bug Something isn't working label Aug 5, 2024
@mcanouil
Copy link
Collaborator

mcanouil commented Aug 5, 2024

Does the following path is correct in your machine? /Applications/Microsoft Edge.app/Contents/MacOS/Microsoft Edge

@Steinthal
Copy link
Author

ls -l /Applications/Microsoft\ Edge.app/Contents/MacOS/
total 920
-rwxrwxr-x  1 USER  admin  469248  1 Aug 20:33 Microsoft Edge

@mcanouil
Copy link
Collaborator

mcanouil commented Aug 5, 2024

The path set in the PR is correct then, so the issue might be the following part:

   return programs.find((p) => {
      safeExistsSync(p);
    });

@mcanouil
Copy link
Collaborator

mcanouil commented Aug 21, 2024

Replacing the code I mentioned with the code below (similarly to Windows) works:

    for (let i = 0; i < programs.length; i++) {
      path = programs[i];
      if (path && existsSync(path)) break;
    }

or

return programs.find(safeExistsSync);

I think the code should also be updated to observe some environment variable, for instance I would personally like to be able to use Brave ("/Applications/Brave Browser.app/Contents/MacOS/Brave Browser")

@mcanouil
Copy link
Collaborator

@mcanouil mcanouil added puppeteer Issues with puppeteer and remote chromium rendering chromium labels Aug 21, 2024
@mcanouil mcanouil added this to the v1.6 milestone Aug 21, 2024
@Steinthal
Copy link
Author

Steinthal commented Aug 22, 2024

I've installed Quarto 1.6.6 but still get the same error…

Anything I can check if some old settings might cause the behavior?

Here's some more info:

USER@Mac % quarto tools 
[✓] Inspecting tools

Tool         Status            Installed     Latest     
chromium     Not installed     ---           869685     
tinytex      Not installed     ---           v2024.07.03



USER@Mac % quarto check
Quarto 1.6.6
[✓] Checking versions of quarto binary dependencies...
      Pandoc version 3.2.0: OK
      Dart Sass version 1.70.0: OK
      Deno version 1.41.0: OK
      Typst version 0.11.0: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
      Version: 1.6.6
      Path: /Applications/quarto/bin

[✓] Checking tools....................OK
      TinyTeX: (not installed)
      Chromium: (not installed)

[✓] Checking LaTeX....................OK
      Using: Installation From Path
      Path: /opt/homebrew/bin
      Version: undefined

[✓] Checking basic markdown render....OK

[✓] Checking Python 3 installation....OK
      Version: 3.12.5
      Path: /opt/homebrew/opt/python@3.12/bin/python3.12
      Jupyter: (None)

      Jupyter is not available in this Python installation.
      Install with python3 -m pip install jupyter

[✓] Checking R installation...........OK
      Version: 4.4.1
      Path: /Library/Frameworks/R.framework/Resources
      LibPaths:
        - /Library/Frameworks/R.framework/Versions/4.4-arm64/Resources/library
      knitr: 1.48
      rmarkdown: 2.28

[✓] Checking Knitr engine render......OK

@mcanouil
Copy link
Collaborator

The PR was not merged as indicated by GitHub and this issue is still open. Why would you expect things to change in a new release?

@Steinthal
Copy link
Author

Sorry, I misread

Other Fixes and Improvements
#10162: Use Edge on macOS as a Chromium browser when available.

@mcanouil
Copy link
Collaborator

mcanouil commented Aug 22, 2024

That's the initial PR you even mentioned in your report, which you already know is not working as intended.

As for every single issues/discussions, we'll update as soon as there is something to update about.

@mcanouil
Copy link
Collaborator

@Steinthal the fix should be part of the next pre-release build.

@Steinthal
Copy link
Author

Just installed 1.6.7 and can confirm that the fix is working . Thanks a lot, guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chromium puppeteer Issues with puppeteer and remote chromium rendering
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants