-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert EndUserSpanProcessor integration #39648
Conversation
/cc @radcortez (opentelemetry) |
Status for workflow
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
I merged it but I'm not entirely sure how we should handle it in currently maintained branches. Should we at least backport the removal of the documentation and mark the config as deprecated so that people don't see it in the doc? |
+1 for removal via backports because to fix this there would require a lot of work. Fixing it for main is doable. |
Yeah problem is that removing a feature with a backport is definitely too aggressive IMO. I would:
That means except if using it could lead to serious issues. In this case, yes, we could discuss dropping it. But we would need a broader discussion than here in the comment section of a PR. |
My bit: Risks are ugly warning, unreliable feature. I think raised exceptions won't have recognizable impact on resources. I think @brunobat will have a plan what to do. |
I agree on creating a backport PR including:
|
Remove the functionality due to reliability issues.
Mitigates ##39563
The feature will be later re-implemented.
Original implementation: #34595