Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core module is using a mix of traditional @ConfigRoot and @ConfigMapping #42114

Open
gsmet opened this issue Jul 24, 2024 · 5 comments · Fixed by #42157 · May be fixed by #44079
Open

Core module is using a mix of traditional @ConfigRoot and @ConfigMapping #42114

gsmet opened this issue Jul 24, 2024 · 5 comments · Fixed by #42157 · May be fixed by #44079
Labels
area/config kind/enhancement New feature or request
Milestone

Comments

@gsmet
Copy link
Member

gsmet commented Jul 24, 2024

@radcortez if you want to help, it would be nice if you could make sure the quarkus-core modules (runtime and deployment) uniformly use @ConfigMapping (or @ConfigRoot, your choice but I suspect you will choose the former).

This won't be allowed anymore with the new annotation processor.

See PackageConfig for @ConfigMapping and ShutdownBuildTimeConfig for traditional @ConfigRoot.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 24, 2024

/cc @radcortez (config)

@radcortez
Copy link
Member

Sure

@gsmet
Copy link
Member Author

gsmet commented Jul 25, 2024

SmallRye Reactive Messaging is also in the way with ReactiveMessagingConfiguration and HealthCenterFilterConfig.

@gsmet
Copy link
Member Author

gsmet commented Jul 25, 2024

FWIW, we will unfortunately need this fixed before we can think about merging the new annotation processor. I'm iterating on the full build atm to detect all the issues.

@radcortez
Copy link
Member

Ok. I'll work on this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config kind/enhancement New feature or request
Projects
None yet
2 participants