Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create OTel IdGenerator tests #34668

Closed
brunobat opened this issue Jul 11, 2023 · 3 comments · Fixed by #35694
Closed

Create OTel IdGenerator tests #34668

brunobat opened this issue Jul 11, 2023 · 3 comments · Fixed by #35694
Labels
area/tracing good first issue Good for newcomers kind/enhancement New feature or request
Milestone

Comments

@brunobat
Copy link
Contributor

brunobat commented Jul 11, 2023

Description

We are missing IdGenerator tests to prove the correct integration.
The tests were working with AWS ID Generator and we don't want that dependency on the main extension.

See: io.quarkus.opentelemetry.deployment.OpenTelemetryIdGeneratorTest

Implementation ideas

No response

@brunobat
Copy link
Contributor Author

We need to create an ID generator that is not AWS dependent, use it and see if it works.

@brunobat
Copy link
Contributor Author

In relation to the AWS ID itself it would be nice to have a test project for AWS lambdas that could also use this, however, this a much bigger task.

@brunobat brunobat removed their assignment Aug 25, 2023
@brunobat brunobat added the good first issue Good for newcomers label Aug 25, 2023
@mskacelik
Copy link
Contributor

Gonna have a look at the ID generators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracing good first issue Good for newcomers kind/enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants