Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure the /q endpoint (or subset) in Prod more by default #25001

Closed
phillip-kruger opened this issue Apr 19, 2022 · 4 comments · Fixed by #30506
Closed

Secure the /q endpoint (or subset) in Prod more by default #25001

phillip-kruger opened this issue Apr 19, 2022 · 4 comments · Fixed by #30506

Comments

@phillip-kruger
Copy link
Member

Description

Currently users can include certain /q endpoints in a PROD profile. Some of these endpoint should be secured, but currently it's up to the user to do this, and by default, when including this, it will be unsecure.

This feature request suggest to change the default in the above case to secure, and let the user either 1) secure it themselves using their own security model, or 2) explicitly remove the security, or 3) keep the generated default security.

The generated default security could be a basic auth, that use admin and a generated password that print on startup ? Or just an admin key that print on startup.

Some /q services should always be open (like health). So this might only apply to certain services under /q , or health should be moved out of /q ?

cc @maxandersen @Sanne

Implementation ideas

No response

@sberyozkin
Copy link
Member

I think this issue should be resolved, if it is to be resolved, as part of #5485.

I'm not sure it makes sense to selectively secure some /q endpoints if the rest of the application remains insecure by default

@sberyozkin
Copy link
Member

sberyozkin commented Apr 19, 2022

Perhaps it is not worth mixing this issue with #5485. But managing the admin passwords out of the box (ex if basic auth is enabled for some /q/*) would require persisting them with all security related follow ups required (PEN testing, configuration management review, etc at the RHBQ level) - Quarkus will become an application itself. It is not a blocker in itself but something which is worth considering too when deciding how to approach it

@brunobat
Copy link
Contributor

brunobat commented Jan 2, 2023

We got more users requesting this feature @sberyozkin @phillip-kruger

@geoand
Copy link
Contributor

geoand commented Jan 26, 2023

Won't this be dealt with when we have #23429?

@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants