You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just tripped over a little inconsistency in ResultHandle. The getResultType method is public:
public ResultType getResultType() {
return this.resultType;
}
... but the ResultType class is package-private.
I'd submit a PR to either make the method package private or make the type public, but I wasn't sure which was preferable. Maybe there's a reason for it to be package private?
The text was updated successfully, but these errors were encountered:
One reason to make the method package private (maybe, sorta) is that getType() is package private, and it's arguably the more useful of the two methods. So it might be strangely inconsistent to have getResultType public but not getType.
I don't think getResultType() is ever useful outside of Gizmo internals. I would make that method package-private, personally.
On the other hand, getType(), which is the "static" type of the value, that indeed can be useful, except the String representation is super user-unfriendly...
I just tripped over a little inconsistency in ResultHandle. The
getResultType
method is public:... but the
ResultType
class is package-private.I'd submit a PR to either make the method package private or make the type public, but I wasn't sure which was preferable. Maybe there's a reason for it to be package private?
The text was updated successfully, but these errors were encountered: