Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow named configurations #35

Open
turing85 opened this issue Oct 21, 2022 · 4 comments
Open

Allow named configurations #35

turing85 opened this issue Oct 21, 2022 · 4 comments

Comments

@turing85
Copy link
Contributor

Since we now have the capability of named configurations in quarkus-artemis (#20), we should also implement them for pooled connections.

@turing85
Copy link
Contributor Author

turing85 commented Oct 21, 2022

@zhfeng, @middagj I'd like to start a discussion. I think it is worthwhile to fully integrate this extension into quarkus-artemis, i.e. merging the code of this extension into quarkus-artemis.

The plan would be to move all configuration options under the key quakrus.artemis, and process everything in quarkus-artemis. From what I see, integration looks straight-forward: replace the Artemis wrapper in quarkus-artemis with the Wrapper in this extension, and merge the configuration options.

What do you guys think? Would this be an option?

@turing85 turing85 changed the title Allow named configuration Allow named configurations Oct 21, 2022
@middagj
Copy link

middagj commented Oct 22, 2022

If it is still a separate extension people can opt to include I would welcome it. But, this is more a question for the current owner. Pooled JMS is not specifically tied to any JMS implementation. I don't know how they see the future and if they want to be an extension to artemis-jms or want to keep their independence.

@zhfeng
Copy link
Contributor

zhfeng commented Oct 24, 2022

Thanks @turing85 , I'd like to keep it as a seperate extension as it targets for a generic solution to wrap all the JMS implementations. I had raised a discussion on quarkus-dev https://groups.google.com/g/quarkus-dev/c/thdTCj-XNUU. It looks like a CDI decorator could be helpful. I will keep you update.

@turing85
Copy link
Contributor Author

Hm... I see. I am, however, somewhat dissatisfied that we would have to define everything twice (once for the actual configuration, once for pooling). But to be honest, I see not way to fix this except for restructuring the whole messaging-concept within quarkus, grouping everything under a common key (as it is done with datasource). Or is there another way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants