Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keys to override config for chat, embedding and image-model for Azure OpenAI #1177

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add keys to override config for chat, embedding and image-model for Azure OpenAI #1177

wants to merge 1 commit into from

Conversation

flyinfish
Copy link

@flyinfish flyinfish commented Dec 20, 2024 •
edited by geoand
Loading

For chat, embedding, and image-model: api-key, ad-token, api-version

config: add keys to override config
89b947d 
for chat-, embedding-, and image-model: api-key, ad-token, api-version

Closes quarkiverse#1154
@flyinfish flyinfish requested a review from a team as a code owner December 20, 2024 18:06
@flyinfish
Copy link
Author

flyinfish commented Dec 20, 2024 •
edited
Loading

@geoand
that should be pretty much it

i include ad-token and api-version as they have the same problem.
with api-version im not to sure, might not help an awful lot

@flyinfish flyinfish changed the title config: add keys to override config azure-openai-config: add keys to override config for chat-, embedding and image-model Dec 20, 2024
@flyinfish flyinfish changed the title azure-openai-config: add keys to override config for chat-, embedding and image-model azure-openai-config: add keys to override config for chat-, embedding- and image-model Dec 20, 2024
@geoand
Copy link
Collaborator

geoand commented Dec 23, 2024

Thanks @flyinfish!

@csotiriou WDYT?

@geoand geoand changed the title azure-openai-config: add keys to override config for chat-, embedding- and image-model Add keys to override config for chat, embedding and image-model for Azure OpenAI Dec 23, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Dec 23, 2024

Status for workflow Build (on pull request)

This is the status report for running Build (on pull request) on commit 89b947d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure OpenAI auth - not possible to specify api-key for (default)embedding-model
2 participants
@flyinfish @geoand