Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to better present config options #56

Open
ppalaga opened this issue Sep 27, 2023 · 4 comments
Open

Figure out how to better present config options #56

ppalaga opened this issue Sep 27, 2023 · 4 comments

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Sep 27, 2023

In Quarkus CXF we often have longer docs for the individual config options, sometimes explaining various possible values, sometimes giving code examples. I guess there is some potential to find a better way how to present it.

This is how it currently looks like:
https://docs.quarkiverse.io/quarkus-cxf/dev/reference/extensions/quarkus-cxf.html
image

I am aware that the fix would not go to antora-ui-quarkiverse, but still, I believe this the best place to discuss the direction.

@ppalaga
Copy link
Contributor Author

ppalaga commented Sep 27, 2023

An idea how this could be solved: Type and default would not be in a separate column

A. The'd either be on the same line with the property name,

quarkus.cxf.codegen.wsdl2java.includes · list of string · no default, required

or

B. Be placed under it on separate lines

quarkus.cxf.codegen.wsdl2java.includes

  • list of string
  • no default, required

The property description could then stretch through the whole width of the page.

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 4, 2023

Do you happen to have any opinion on this @holly-cummins?

Another related question is how could we render the @since information for those options where it is available in the associated Java member. It is currently ignored altogether. moved to #64

@ppalaga
Copy link
Contributor Author

ppalaga commented Dec 22, 2023

Any opinion on this @holly-cummins?

@maxandersen
Copy link
Member

a simple fix for this one is having the columns be top aligned.

so it at least the key, type and value visually is on same line.

About the large chunk of docs (which is not the general case) I'm not sure we can do much.

Not sure when your screenshot is from but on my screen the whitespace issue is not as profound:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants