Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check/build-protos doesn't work anymore #4135

Closed
balopat opened this issue May 26, 2021 · 3 comments
Closed

check/build-protos doesn't work anymore #4135

balopat opened this issue May 26, 2021 · 3 comments
Labels
area/checks kind/health For CI/testing/release process/refactoring/technical debt items

Comments

@balopat
Copy link
Contributor

balopat commented May 26, 2021

Description of the issue

check/build-protos doesn't work, due to cirq-google/.. path having a dash in the name :(
We need to figure out how to get around this.

It is not urgent, as TFQ is the only user for this, and there we strip that prefix, so it doesn't cause issues during the bazel build. However, it is a bit ugly that we can't run check/build-protos ourselves. It also doesn't update the protos correctly - like dev_tools/build-protos.sh does...maybe we should just get rid of it?

@balopat balopat added the kind/health For CI/testing/release process/refactoring/technical debt items label May 26, 2021
@balopat balopat changed the title Proto compilation scripts don't work anymore check/build-protos doesn't work anymore May 26, 2021
@dabacon
Copy link
Collaborator

dabacon commented May 26, 2021

Curious if there was a reason for the hyphen in the filename naming? Was planning on following a similar pattern in another project, and am leaning towards using underscore, but was curious if there was some strange packaging reason to not do this.

@balopat
Copy link
Contributor Author

balopat commented May 27, 2021

I just simply wanted to follow the pypi package name e.g. the cirq-google pypi package offers the cirq_google namespace. The hypen in the filenames is a bazel issue - more info at bazelbuild/bazel#6841.

@pavoljuhas
Copy link
Collaborator

resolved by #6747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/checks kind/health For CI/testing/release process/refactoring/technical debt items
Projects
None yet
Development

No branches or pull requests

6 participants