Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What platform is it compatible with ? #1

Open
svax974 opened this issue May 28, 2023 · 7 comments
Open

What platform is it compatible with ? #1

svax974 opened this issue May 28, 2023 · 7 comments

Comments

@svax974
Copy link

svax974 commented May 28, 2023

Hello,

I tried to build ta-box with python 3.11 on macOS but end up quickly with compilation errors. Are there known compatibility limits ?
Thanks

`
[20/21] Cythonizing tabox/ta_func/ta_WMA.py

Error compiling Cython file:

...

    # Prepare the periodSum for the next iteration.
    periodSum -= periodSub

# Set output limits.
outNBElement[0] = outIdx

^

tabox/ta_func/ta_WMA.py:115:4: local variable 'outNBElement' referenced before assignment

Error compiling Cython file:

...
# Prepare the periodSum for the next iteration.
periodSum -= periodSub

# Set output limits.
outNBElement[0] = outIdx
outBegIdx[0] = startIdx

^

tabox/ta_func/ta_WMA.py:116:4: local variable 'outBegIdx' referenced before assignment
warning: tabox/ta_func/ta_WMA.py:81:26: Index should be typed for more efficient access
`

@jstzwj
Copy link
Contributor

jstzwj commented May 28, 2023

This error might be caused due to the fact that the WMA function has not been finished yet.

@jstzwj
Copy link
Contributor

jstzwj commented May 28, 2023

I'm currently testing with Windows and Linux. Because no platform-related features are used, MacOS should work too. Compared to Ta-LIB, TA-Box is still under development and missing many functions.

@svax974
Copy link
Author

svax974 commented May 28, 2023

Oh right, the marks mark ported indicators I guess.
I can't install it with pip either (get compilation errors in ACOS).
The pure python implementation is a great idea, that would allow to use it in many more contexts.
Keep up the great work ! I'll watch your repo.

@jstzwj
Copy link
Contributor

jstzwj commented May 28, 2023

Thanks for your attention, I will temporarily remove the WMA function in main branch and switch another branch for development to make pip install from main branch possible. Besides, my future plan is using ChatGPT to convert some C functions into Python.

@svax974
Copy link
Author

svax974 commented May 28, 2023

Thanks, I might try to play a bit with ta-box if I can get it to install.
Tell me when I can try to pip install again, thanks !

@jstzwj
Copy link
Contributor

jstzwj commented May 28, 2023

I updated the main branch, you can try the command pip install git+https://github.com/quantmew/ta-box.git to install ta-box now.

@svax974
Copy link
Author

svax974 commented May 28, 2023

Well, installation is ok and a quick test with the simple Add function is good too.
Thanks, I can't wait to see more functions implemented ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants