Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release planning #14

Closed
phillipod opened this issue May 5, 2015 · 22 comments
Closed

Release planning #14

phillipod opened this issue May 5, 2015 · 22 comments
Assignees
Milestone

Comments

@phillipod
Copy link
Collaborator

So the point raised in #13 regarding moving to version 3.1.x is interesting.

I'd like to see an 3.0.x API compatible release with recent bugfixes and enhancements, and ideally, I'd like the developer test suite I'm working on shipped with this release, so as to aid development during the API changes.

However, if API changes are possible within 3.1.x, it may be worth considering a few other things as well - such as providing emulated versions of ldap_url_search() for OpenLDAP, dropping functions not common across the target SDK's, or otherwise gracefully handling the lack of the ldap_url_search() methods (use of the LDAP_VENDOR_NAME and LDAP_NOT_SUPPORTED might do the trick here, in which case it could target 3.0.4).

I'll setup a couple of milestones on github, one targeting 3.0.4 and one targeting 3.1.0 to aid planning.

Will keep this ticket open till the release plan has been completed.

@phillipod phillipod self-assigned this May 5, 2015
@phillipod phillipod added this to the 3.0.4 milestone May 5, 2015
@phillipod
Copy link
Collaborator Author

Milestones for 3.0.4 and 3.1.0 have been created. Scheduling is currently arbitrary.

@phillipod
Copy link
Collaborator Author

I think we're pretty well ready to let this one fly once #36 is merged in, pending any testing.

@quanah
Copy link
Owner

quanah commented Jun 15, 2015

Ok, still on my to-do to do some testing. My work has been extremely busy. :/

@phillipod
Copy link
Collaborator Author

All good, I know what its like :)

@quanah
Copy link
Owner

quanah commented Sep 22, 2015

Apparently something changed between OpenLDAP 2.4.40 and 2.4.42 that broke Net::LDAPapi's ability to function as a syncrepl change listener. I'm currently investigating that issue. I hope to have an example "listener" put into my ldap-tools repository soon, which could be used as a template for a basic test in the future.

@quanah
Copy link
Owner

quanah commented Oct 30, 2015

Ok, I think we are good to release. The issue with syncrepl I am unable to reproduce, and would be an openldap issue and not one with net::ldapapi either way.

@phillipod
Copy link
Collaborator Author

Hey,

Sounds good. Would you like me to prep a tar.gz for CPAN and send it to you?

Cheers,
Phillip

@quanah
Copy link
Owner

quanah commented Nov 4, 2015

Sure, that'd be great! And I guess lay down the appropriate tag?

@whm
Copy link

whm commented Nov 27, 2015

I was looking to pick up pushing the new release to debian testing through Russ Allbery. Is there any one else picking doing this?

I also had some questions about the repo structure. Will release versions be added to the branches directory. Is that how releases are marked?

@phillipod
Copy link
Collaborator Author

@quanah Sorry for the delay - work is hectic as always. https://odonnell.net.nz/files/Net-LDAPapi-3.0.4.tar.gz - built against commit 91107fb in my latest pull request (Updated MANIFEST file), which is based off accded0 (your update contact address commit)

I do have a separate branch with $VERSION in LDAPapi.pm updated to 3.0.4 (https://github.com/phillipod/net-ldapapi/tree/release-3.0.4) - I assume you want the release tag version to include this update but I'm not sure how to submit a pull request to a branch that doesn't exist in your tree :)

Happily, I have 6 weeks off work starting Tuesday and would definitely like to get 3.1 well underway during this time.

@phillipod
Copy link
Collaborator Author

@whm I figure since packages.debian.org shows you and Russ both as maintainers for the .deb, it'd make sense for you to grab this (which would be much appreciated, since I run lots of Debian systems!)

I'm not sure about the repository structure either - I think this git repo was a subversion import. I personally prefer the release tag / branch style, but I'll leave that up to @quanah, since it's his repository

@phillipod
Copy link
Collaborator Author

@quanah Sorry, forgot to mention:

$ md5sum Net-LDAPapi-3.0.4.tar.gz
aa887cde6a28ea647f3207bb07b1ac04  Net-LDAPapi-3.0.4.tar.gz

@quanah
Copy link
Owner

quanah commented Nov 30, 2015

@phillipod Yeah, it was just pulled in via subversion from sourceforge, and hasn't had much done past that. ;) Let me see what I can do about creating a different branch for 3.0.4

@quanah
Copy link
Owner

quanah commented Nov 30, 2015

@phillipod Ok, I've cleaned up the repo and its structure. ;)

@quanah
Copy link
Owner

quanah commented Dec 1, 2015

@phillipod you should be able to push me a merge now for the release-3.0.4 branch . ;)

@phillipod
Copy link
Collaborator Author

Done, and:

$ md5sum Net-LDAPapi-3.0.4.tar.gz
345446714d5cb9429a0009ed41db528f  Net-LDAPapi-3.0.4.tar.gz

https://odonnell.net.nz/files/Net-LDAPapi-3.0.4.tar.gz

@quanah
Copy link
Owner

quanah commented Dec 1, 2015

Hm, this release stuff via github is a bit funky. It created v3.0.4.tar.gz

@phillipod
Copy link
Collaborator Author

That is a bit funky.

Differences are (net-ldapapi-3.0.4 = v3.0.4.tar.gz, Net-LDAPapi-3.0.4 = Net-LDAPapi-3.0.4.tar.gz) :

# diff -Bbur net-ldapapi-3.0.4 Net-LDAPapi-3.0.4
Only in net-ldapapi-3.0.4/examples: ldapwalk-dieter.pl
Only in net-ldapapi-3.0.4/examples: testurl.pl
Only in net-ldapapi-3.0.4: .gitignore
diff -Bbur net-ldapapi-3.0.4/MANIFEST Net-LDAPapi-3.0.4/MANIFEST
--- net-ldapapi-3.0.4/MANIFEST  2015-12-01 16:47:16.000000000 +1300
+++ Net-LDAPapi-3.0.4/MANIFEST  2015-12-01 16:01:58.000000000 +1300
@@ -45,3 +45,4 @@
 t/features/delete.feature
 t/01-bdd-cucumber.t
 t/test-config.pl
+META.json                                Module JSON meta-data (added by MakeMaker)
Only in Net-LDAPapi-3.0.4: META.json
Only in Net-LDAPapi-3.0.4: META.yml
Only in net-ldapapi-3.0.4: README.md

so it would certainly be my preference to have the 'make dist' output linked on the release page.

Looks like other files can be attached to the release via drag and drop, so maybe that will do it?

@phillipod
Copy link
Collaborator Author

coughs Whoops. Monday is November 30th, not December 1st.

@quanah
Copy link
Owner

quanah commented Dec 1, 2015

Yeah, will see if I can update the release with the bits generated by make dist, and just use that for future releases as well.

@quanah
Copy link
Owner

quanah commented Dec 1, 2015

@phillipod ok updated with a new make dist with your latest changes. :)

@quanah
Copy link
Owner

quanah commented Dec 1, 2015

Also updated CPAN.

@quanah quanah closed this as completed Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants