avoid missing bounds error onAppear and use the already available win…

…dows center method
qooxdoo · Apr 4, 2021 · 6a221ee · 6a221ee
1 parent 5944528
commit 6a221ee
Showing 1 changed file with 14 additions and 15 deletions.
diff --git a/source/class/qxl/dialog/Dialog.js b/source/class/qxl/dialog/Dialog.js
@@ -196,20 +196,8 @@ qx.Class.define("qxl.dialog.Dialog", {
     // handle focus
     qx.ui.core.FocusHandler.getInstance().addRoot(this);
     // resize the window when viewport size changes
-    root.addListener("resize", () => {
-      let bounds = this.getBounds();
-      this.set({
-        marginTop: Math.round((qx.bom.Document.getHeight() - bounds.height)/2),
-        marginLeft: Math.round((qx.bom.Document.getWidth() - bounds.width)/2)
-      });
-    });
-    this.addListener("appear", () => {
-      let bounds = this.getBounds();
-      this.set({
-        marginTop: Math.round((qx.bom.Document.getHeight() - bounds.height)/2),
-        marginLeft: Math.round((qx.bom.Document.getWidth() - bounds.width)/2)
-      });
-    });
+    this.addListener("resize", this.center, this);
+    root.addListener("resize", this.center, this);
     this._createWidgetContent(properties);
     // set properties from constructor param
     if (typeof properties == "object") {
@@ -218,7 +206,7 @@ qx.Class.define("qxl.dialog.Dialog", {
       this.setMessage(properties);
     }
     // escape key
-    qx.core.Init.getApplication().getRoot().addListener("keyup", this._handleEscape, this);
+    root.addListener("keyup", this._handleEscape, this);
   },
 
   properties: {
@@ -314,5 +302,16 @@ qx.Class.define("qxl.dialog.Dialog", {
       this.setVisibility("hidden");
       return this;
     }
+  },
+
+  /*
+  ***********************************************
+    DESTRUCTOR
+  ***********************************************
+  */
+  destruct: function () {
+    let root = qx.core.Init.getApplication().getRoot();
+    root.removeListener("resize", this.center, this);
+    root.removeListener("keyup",this._handleEscape,this);
   }
 });