Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Manager: Tries to open last tab of main server (when remotely logged in) #523

Closed
divyeshsachan opened this issue Aug 4, 2016 · 5 comments

Comments

@divyeshsachan
Copy link

When logged in via remote (using webmin server index), file manager tries to open last tab of main server instead of that specific server. However, this is not a serious issue, but since i use file manager of my all servers via webmin remote login, i want to bring it up into your notice.
Steps to reproduce:

  1. Open File Manager and navigate to unique folder path.
  2. Navigate to "Webmin Servers Index" and open another server from there (webmin remote login to another webmin server).
  3. Open "File Manager" on this remotely logged in server.
    Now, file manager in remote server tries to open last path of main webmin's file manager and if this path doesn't exists in remote server, it shows an error that directory not found.

I think this issue somehow related to Issue#478. You have fixed it for per user and i think you should also add a check for specific server and open last opened tab of that server.

Thanks for your precious time and effort.

@iliajie
Copy link
Collaborator

iliajie commented Aug 4, 2016

Oh, that sounds very possible. It's the last thing I would do/redo again but I'll try.

Thanks for reporting.

@iliajie
Copy link
Collaborator

iliajie commented Oct 29, 2016

Enhancements will be done in 18.30. Please be patience.

@iliajie
Copy link
Collaborator

iliajie commented Nov 22, 2016

All of the localStorage now is tied to the hostname for all operations. It'll work not only for File Manager tabs but for all other operations.

@iliajie iliajie closed this as completed Nov 22, 2016
@divyeshsachan
Copy link
Author

Will these changes be applied in any upcoming version ?

@iliajie
Copy link
Collaborator

iliajie commented Nov 22, 2016

Version 18.30 will drop all of the current settings. Afterwards, it will be preserved in the browser's cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants