Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Using mobile device, can not scroll to bottom of system/ boot up shutdown page (Safari iOS 9) #394

Closed
Madseason41 opened this issue Feb 17, 2016 · 48 comments
Labels

Comments

@Madseason41
Copy link

When using an iPhone 6 on safari I can not scroll to bottom of the boot up shutdown page. Upon touching the screen to continue scrolling, the page automatically returns to the top.

@iliajie
Copy link
Collaborator

iliajie commented Feb 17, 2016

I don't know how to reproduce it as I don't have an iPhone. I will see what I can do, probably ask someone. Are there emulators for that? Because if I use Safari emulation, all works fine?

@Madseason41
Copy link
Author

I should have mentioned, 1.780 and 17.70 are the Webmin and theme versions.

@iliajie
Copy link
Collaborator

iliajie commented Feb 17, 2016

Other pages scrolled correctly?

@Madseason41
Copy link
Author

Works fine on desktop safari, and on mobile version of chrome.

With mobile safari I get the same behavior on the file manager tab. As soon as I touch the screen a second time to continue scrolling to the bottom, the screen returns to the top. I can never get to the bottom of the page.

@iliajie
Copy link
Collaborator

iliajie commented Feb 17, 2016

That sounds very strange. Are you on iOS beta version?

@Madseason41
Copy link
Author

No beta

@iliajie iliajie changed the title Using mobile device, can not scroll to bottom of system/ boot up shutdown page Using mobile device, can not scroll to bottom of system/ boot up shutdown page (iOS) Mar 3, 2016
@iliajie iliajie changed the title Using mobile device, can not scroll to bottom of system/ boot up shutdown page (iOS) Theme: Using mobile device, can not scroll to bottom of system/ boot up shutdown page (iOS) Mar 8, 2016
@iliajie iliajie changed the title Theme: Using mobile device, can not scroll to bottom of system/ boot up shutdown page (iOS) Theme: Using mobile device, can not scroll to bottom of system/ boot up shutdown page (Safari iOS 9) Mar 11, 2016
@SteffanCline
Copy link

I thought I posted this before. If you install XCode on your MacBook Pro, you can use the iOS Simulator to preview your work. Works great and lets you test on all iOS Devices. There's even a WatchOS simulator too. haha.

/Applications/Xcode.app/Contents/Developer/Applications/Simulator.app

@iliajie
Copy link
Collaborator

iliajie commented Apr 10, 2016

Yes, I remember. I just haven't had chance to do it yet.

@jo-tez
Copy link

jo-tez commented May 12, 2016

Same issue here. Lovely theme, just so frustrating that it's almost unusable on iPhone 6

@iliajie
Copy link
Collaborator

iliajie commented May 12, 2016

I'll take a look. It's not closed. :)

I have a lot of other major improvements to do now. I will install XCode of my Mac sooner or later and try fixing it. (in case it's not going to be resolved by upcoming 18.00)

@iliajie
Copy link
Collaborator

iliajie commented Jun 2, 2016

This issue should be solved in 18.00.

Report back please.

@jo-tez
Copy link

jo-tez commented Jun 2, 2016

Sadly the issue persists on the home (System information) page. As soon as I scroll down, it starts re-rendering the page.

On the plus side, the new version appears to have resolved this issue on other pages, e.g. Postfix configuration page, which was really annoying.

@iliajie
Copy link
Collaborator

iliajie commented Jun 2, 2016

I honestly have no idea why in the World that would happen.

Glad to hear about other issues got resolved. I bet you can't reproduce it on iPhone using Chrome/Firefox, right?

@jo-tez
Copy link

jo-tez commented Jun 2, 2016

That's what I thought, but I was able to reproduce it on both Chrome and Firefox for iOS

@iliajie
Copy link
Collaborator

iliajie commented Jun 2, 2016

Really!?

Let me see...

Alright, have a look. This is Chrome on Android 6.0.1:
http://rostovtsev.ru/pub/src/authentic/18.01b/working_scroll_under_chrome.mp4

Tell me something, what if you click option Menu on top right and select Display Desktop version of the site, does it do anything?

@iliajie
Copy link
Collaborator

iliajie commented Jun 6, 2016

Did you try Desktop mode? It should help.

@iliajie
Copy link
Collaborator

iliajie commented Jun 9, 2016

Any news here? Switching to desktop helps, right?

@jo-tez
Copy link

jo-tez commented Jun 12, 2016

It makes no difference. I'll try to create a short video to this

@iliajie
Copy link
Collaborator

iliajie commented Jun 12, 2016

Ok, thanks!

@jo-tez
Copy link

jo-tez commented Jun 12, 2016

https://vimeo.com/170363558
This is on my live server, so I set a password to protect my details. I'll send you the password via your website contact form now.

@iliajie
Copy link
Collaborator

iliajie commented Jun 12, 2016

Ok.

@iliajie
Copy link
Collaborator

iliajie commented Jun 12, 2016

This is bizarre! I have not even remote idea of why this is happening!

What about Chrome?

@iliajie
Copy link
Collaborator

iliajie commented Jun 12, 2016

.. or that was Chrome?

@jo-tez
Copy link

jo-tez commented Jun 12, 2016

I tried everything, Chrome and Firefox for iOS and switching to Desktop mode. No worries, I can live with this 😄 It used to happen on every page, which made the theme almost unusable. Now it only happens on the front page, so it's not a major issue

@iliajie
Copy link
Collaborator

iliajie commented Jun 12, 2016

Hmm.. Really!? All other pages were fixed after 18.00?

..hmm...

@jo-tez
Copy link

jo-tez commented Jun 12, 2016

Yeah other pages were fixed after 18.00 - I know because before it was really annoying to save any changes, e.g. to Postfix settings, because by the time I scrolled to the bottom to Save, the page would bounce back up. This is not happening anymore, which is great.

@iliajie
Copy link
Collaborator

iliajie commented Jun 12, 2016

Wow! Cool!

.. I have set it all in my mind now. ..maybe the solution will come by itself, maybe not. .. I'm intended to fix it, whenever it is..

Thanks, pal.

@casparz
Copy link

casparz commented Jul 22, 2016

This problem stil exists. It sounds related to a problem described here: kbwood/countdown#50
Could you check if this is the same issue? Looks like iOS Safari doesn't like iframes.

@iliajie
Copy link
Collaborator

iliajie commented Jul 22, 2016

What theme version do you have installed?

@iliajie
Copy link
Collaborator

iliajie commented Jul 22, 2016

Interesting post in the link, thanks. Could you try the solution that is in this StackOverflow answer?

@casparz
Copy link

casparz commented Jul 22, 2016

This is the solution, after adding the css style snippet in the StackOverflow answer to the theme extension styles.css the page no longer snaps back to the top on my iPhone. I am running version 18.03 af the theme.
Thank you!

@iliajie
Copy link
Collaborator

iliajie commented Jul 22, 2016

Oh, that is nice. Finally. OK. Do you have any changes on Desktop version? Will it work if you remove height property?

@iliajie iliajie added bug and removed question labels Jul 22, 2016
@casparz
Copy link

casparz commented Jul 22, 2016

Removing the height property has no influence. Removing the overflow however causes the jumping behaviour to return. I have not encountered any negative effects in desktop safari so far.

@iliajie
Copy link
Collaborator

iliajie commented Jul 22, 2016

Thanks, pal. I might release a fixed version very soon.

@casparz
Copy link

casparz commented Jul 22, 2016

YW, thank you for developing the theme!

@iliajie
Copy link
Collaborator

iliajie commented Jul 22, 2016

Will be fixed in 18.04 within an hour.

@iliajie iliajie closed this as completed Jul 22, 2016
@iliajie
Copy link
Collaborator

iliajie commented Jul 22, 2016

18.04 is out, please upgrade! 😉

@jo-tez
Copy link

jo-tez commented Nov 16, 2016

This issue is back in 18.20 :(

@iliajie
Copy link
Collaborator

iliajie commented Nov 16, 2016

It truly don't see how it's possible. I haven't done any changes.

However, I'll double check.

@casparz
Copy link

casparz commented Nov 16, 2016

I can conform that it is back. When I reapply the custom CSS mentioned earlier the issue goes away again.

@iliajie
Copy link
Collaborator

iliajie commented Nov 16, 2016

@casparz could you please post your custom CSS please?

@casparz
Copy link

casparz commented Nov 16, 2016

@qooob
html, body {
overflow: auto;
-webkit-overflow-scrolling: touch;
}

@iliajie
Copy link
Collaborator

iliajie commented Nov 16, 2016

Here is why I removed it, I even commented it. Try it only on body tag:

/* When usingoverflow: autoon <html> -window.scrollTo(0,document.body.scrollHeight)doesn't work*/

@iliajie
Copy link
Collaborator

iliajie commented Nov 16, 2016

Ahh, well. It wouldn't work.

@iliajie
Copy link
Collaborator

iliajie commented Nov 16, 2016

It's only happening in Safari browser?

@iliajie
Copy link
Collaborator

iliajie commented Nov 16, 2016

Hi,

Here is the fix that will satisfy all. Please add it to your custom scripts.js extension and check it on Safari in iOS:

const __ua__ = window.navigator.userAgent,
    ___is_iOS = (!!__ua__.match(/iPad/i) || !!__ua__.match(/iPhone/i)),
    ___is_webkit = (!!__ua__.match(/WebKit/i)),
    ___is_iOSSafari = (___is_iOS && ___is_webkit && !__ua__.match(/CriOS/i) && !__ua__.match(/OPiOS/i));

// Mobile Safari (iOS) fix with pages not scroll to bottom issue #394
(___is_iOSSafari &&
    ($('html').css('overflow', 'auto'))
)

@casparz
Copy link

casparz commented Nov 16, 2016

I can confirm it works! Thanks again.

@iliajie
Copy link
Collaborator

iliajie commented Nov 16, 2016

Great. I will add it to 18.30. Now all will be happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants