Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add output file argument to qmk compile #22590

Closed
2 of 4 tasks
leah-splitkb opened this issue Dec 1, 2023 · 5 comments · Fixed by #22887
Closed
2 of 4 tasks

[Feature Request] Add output file argument to qmk compile #22590

leah-splitkb opened this issue Dec 1, 2023 · 5 comments · Fixed by #22887
Labels
enhancement help wanted stale Issues or pull requests that have become inactive without resolution.

Comments

@leah-splitkb
Copy link
Contributor

Feature Request Type

  • Core functionality
  • Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
  • Alteration (enhancement/optimization) of existing feature(s)
  • New behavior

Description

Prior to #22221, the command qmk compile -e CONVERT_TO=liatris --keyboard splitkb/kyria/rev3 --keymap default would produce the file splitkb_kyria_rev3_default_liatris.uf2. After #22221, the same command would produce the file splitkb_kyria_rev3_default.uf2.

Although a minor change and easily resolved, this change did break our CI pipeline and as far as I can tell wasn't documented.

It would be neat if there was a way to do qmk compile (..) --output firmware.uf2. This would get rid of the whole "guess what filename QMK is going to use" part, and make it a lot easier to set up reliable CI pipelines.

@drashna
Copy link
Member

drashna commented Dec 10, 2023

-e TARGET=(name) will do that

@santa4nt
Copy link

I would also suggest adding --output_dir argument, as well.

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Apr 21, 2024
@tzarc
Copy link
Member

tzarc commented Apr 21, 2024

#22887 should sort this out by restoring original behaviour.
Renaming or changing the output filename is a bit more of a complex beast.

@tzarc tzarc linked a pull request Apr 21, 2024 that will close this issue
14 tasks
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Apr 22, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants