Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --deps.bump not working as expected #99

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

csantos1113
Copy link
Contributor

Fixes #83

Changes

Use bumpStrategy instead of releaseStrategy when calling resolveNextVersion

  • New code is covered by tests
  • All the changes are mentioned in docs (readme.md)

@antongolub
Copy link
Member

@csantos1113,

Nice catch! Thanks for the digging.

@antongolub antongolub merged commit a5e526c into qiwi:master Oct 23, 2023
5 checks passed
@csantos1113
Copy link
Contributor Author

csantos1113 commented Oct 23, 2023

@antongolub 😢 because this PR only had one commit, it seems github used that one (instead of the PR title)... and my commit message was wrong. So I'm not sure this will trigger a new release 😢

in fact it didn't trigger a new release: https://github.com/qiwi/multi-semantic-release/actions/runs/6616386710/job/17970551525

@antongolub
Copy link
Member

My fault. I'll take care.

antongolub added a commit that referenced this pull request Oct 23, 2023
github-actions bot pushed a commit that referenced this pull request Oct 23, 2023
## [7.1.1](v7.1.0...v7.1.1) (2023-10-23)

### Performance Improvements

* tech release to publish [#99](#99) ([34328e1](34328e1))
@qiwibot
Copy link
Member

qiwibot commented Oct 23, 2023

🎉 This PR is included in version 7.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@csantos1113
Copy link
Contributor Author

My fault. I'll take care.

Thanks for fixing it 🙏 and sorry for not using semantic-release format for my commits 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--deps.bump=satisfy not working as expected
3 participants