Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make docker building script more flexible #27

Open
jlapeyre opened this issue Apr 7, 2022 · 3 comments
Open

make docker building script more flexible #27

jlapeyre opened this issue Apr 7, 2022 · 3 comments

Comments

@jlapeyre
Copy link
Contributor

jlapeyre commented Apr 7, 2022

The following script for building and running the docker container takes just one argument, which is the action to take

https://github.com/Qiskit-Extensions/qiskit-alt/blob/main/docker_tests/run_dockerfile.sh

It could use another argument, the name or revision of the container, so you can build one for a different branch. Might be better to switch to a python script.

@MozammilQ
Copy link
Contributor

Might be better to switch to a python script.

I am working on the python script. 😄

@garrison
Copy link
Member

garrison commented Aug 6, 2022

Is there anything left to do here beyond #30 and #36?

Related to this issue, I've been considering whether Earthly might be a good fit for testing and deploying qiskit-alt.

@jlapeyre
Copy link
Contributor Author

jlapeyre commented Aug 6, 2022

No, I think there's nothing more. I don't no anything about Earthly. But if it is easy to run locally, that's attractive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants