Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use threaded legend hit test for preview renders #58927

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Only use threaded legend hit test for preview renders #58927

wants to merge 1 commit into from
+4 −8

Conversation

nyalldawson
Copy link
Collaborator

In other cases we'll need a blocking hit test anyway, and we run a risk of deadlocks if a non-preview render is then started on the main thread.

Fixes #58496

@github-actions github-actions bot added this to the 3.40.0 milestone Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024 •
edited
Loading

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit b12342b)

troopa81
troopa81 reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@troopa81 troopa81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this logic still needed ?

If this is preview,we don't wait, and if this is not, there is no thread anymore to wait with your proposal

@nyalldawson
Copy link
Collaborator Author

@troopa81

Is this logic still needed ?
If this is preview,we don't wait, and if this is not, there is no thread anymore to wait with your proposal

Indeed it's not -- I've revised it now to what should be a safe alternative

@nyalldawson
Only use threaded legend hit test for preview renders
b12342b 
In other cases we'll need a blocking hit test anyway, and we
run a risk of deadlocks if a non-preview render is then started
on the main thread.

Fixes qgis#58496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troopa81 troopa81 troopa81 left review comments

Assignees
No one assigned
Labels
backport queued_ltr_backports Queued Backports
Projects
None yet
Milestone
3.40.0
Development

Successfully merging this pull request may close these issues.

Layout Legend Not Syncing with Atlas in QGIS 3.34 LTR and 3.38 Using PyQGIS
2 participants
@nyalldawson @troopa81