Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 3d.pyi install (followup da317dd8dea0) #58562

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

jef-n
Copy link
Member

@jef-n jef-n commented Sep 3, 2024

$ find build -name "*3d*.pyi"
build/python/3d/build/_3d_p/_3d_p.pyi

From the nightlies:

-- Installing: /build/qgis-3.39.0+git20240903+b53968c771e+36jammy/debian/tmp/usr/lib/python3/dist-packages/qgis/_gui.so
-- Set runtime path of "/build/qgis-3.39.0+git20240903+b53968c771e+36jammy/debian/tmp/usr/lib/python3/dist-packages/qgis/_gui.so" to ""
CMake Error at python/cmake_install.cmake:134 (file):
  file INSTALL cannot find
  "/build/qgis-3.39.0+git20240903+b53968c771e+36jammy/debian/build/python/3d/build/3d_p/3d_p.pyi":
  No such file or directory.
Call Stack (most recent call first):
  cmake_install.cmake:69 (include)

$ find build -name "*3d*.pyi"
build/python/3d/build/_3d_p/_3d_p.pyi
@github-actions github-actions bot added this to the 3.40.0 milestone Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit d281342)

@nyalldawson nyalldawson merged commit 640f280 into qgis:master Sep 3, 2024
31 checks passed
@jgrocha
Copy link
Member

jgrocha commented Sep 16, 2024

Hi @jef-n

On my build, I don't get the _3d_p.pyi and so this PR breaks my sudo cmake --build . --target install.

I wrote the details on #58534 (comment)

What is different in my setup?

@nyalldawson
Copy link
Collaborator

@jgrocha what version of sip are you using?

@nirvn
Copy link
Contributor

nirvn commented Sep 16, 2024

I have the same issue, using sip 4.

@jgrocha
Copy link
Member

jgrocha commented Sep 16, 2024

@jgrocha what version of sip are you using?

4.19.25

@jgrocha
Copy link
Member

jgrocha commented Oct 3, 2024

Ping @jef-n

Is there anything we can do about this? Can we add an additional condition to python/CMakeLists.txt to both 3d_p.pyi and _3d_p.pyi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants