Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostGIS digitizing #10190

Closed
qgib opened this issue Jun 1, 2006 · 12 comments
Closed

PostGIS digitizing #10190

qgib opened this issue Jun 1, 2006 · 12 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Vectors Related to general vector layer handling (not specific data formats)

Comments

@qgib
Copy link
Contributor

qgib commented Jun 1, 2006

Author Name: Redmine Admin (Redmine Admin)
Original Redmine Issue: 131

Redmine category:vectors
Assignee: Gary Sherman


When committing [[PostGIS]] digitizing changes to database, in case of even a single error in input (value not allowed) all the editing is lost. Too bad for serious work.

@qgib
Copy link
Contributor Author

qgib commented Jul 10, 2006

Author Name: Brendan Morley - (Brendan Morley -)


Can you provide an example where "value not allowed" occurs?

There are always going to be cases where there may be an error when committing (e.g. disk full, server fallen off network) - perhaps we could do a "save changes but keep editing" feature?

@qgib
Copy link
Contributor Author

qgib commented Jul 10, 2006

Author Name: venturato-faunalia-it - (venturato-faunalia-it -)


1 example: ERROR: insert or update on table "fix_2006" violates foreign key constraint "verifica_id_radio"
DETAIL: Key (id_radio,anno)=(1000,2006) is not present in table "radio_usate".

2 example: ERROR: date/time field value out of range:"31/2/2006".

"save changes but keep editing" might be good, but I think it is better if qgis could keep it im memory, asking the user to edit the wrong value.

@qgib
Copy link
Contributor Author

qgib commented Jul 11, 2006

Author Name: Brendan Morley - (Brendan Morley -)


I see where the problem is and have devised a potential fix on my machine. I'll commit it to subversion in the next few days and let you see if it works for you.


  • status_id was changed from Open to In Progress

@qgib
Copy link
Contributor Author

qgib commented Jul 13, 2006

Author Name: Brendan Morley - (Brendan Morley -)


Should be fixed in 4a6923a (SVN r5592) for both changed attribute values and changed geometries. Can this be tested and the bug closed if appropriate?

@qgib
Copy link
Contributor Author

qgib commented Jul 19, 2006

Author Name: Redmine Admin (Redmine Admin)


The following error now appears (twice) when committing:
ERROR: syntax error at or near "," at character 318
From the database side, we get:
WARNING: non c'è nessuna transazione in corso
and then:
ERROR: current transaction is aborted, commands ignored until end of transaction block
As a result, no data can be input.

@qgib
Copy link
Contributor Author

qgib commented Jul 25, 2006

Author Name: Gavin Macaulay - (Gavin Macaulay -)


The syntax error problem has been fixed in SVN 986ea53 (SVN r5638). Was a problem with blank data fields.


  • resolution was changed from to fixed
  • status_id was changed from In Progress to Closed

@qgib
Copy link
Contributor Author

qgib commented Aug 13, 2006

Author Name: Brendan Morley - (Brendan Morley -)


Further to my commentary on 07/14/06, I got to test it out and it was found wanting. should really fix it, I have put a full writeup on the commit message to .

@qgib
Copy link
Contributor Author

qgib commented Aug 29, 2006

Author Name: venturato-faunalia-it - (venturato-faunalia-it -)


Further testing: the situation is already much better than before, but in my view the correct behaviour would be for the program to stop and display the alphanumumeric digitizing window of the wrong record, so that the user could put the correct values.
Admittedly, in case of errors in multiple records this would be difficult to implement. Perhaps better to automatically commit every record just after insertion?

Additionally, we get frequent crashes while digitizing.


  • resolution was changed from fixed to
  • status_id was changed from Closed to Feedback

@qgib
Copy link
Contributor Author

qgib commented Sep 1, 2006

Author Name: Gavin Macaulay - (Gavin Macaulay -)


Can you provide a gdb backtrace for when it crashes please. Perhaps it is related to ticket #10214?

@qgib
Copy link
Contributor Author

qgib commented Sep 8, 2006

Author Name: Brendan Morley - (Brendan Morley -)


The kind of refinement described in 08/29/06 15:53:14 is no longer a trivial change, and so I will push back that aspect of it to a post-0.8 timeframe.

Even then it would be fairly difficult to address any more than the first error in a commit. Maybe for each change, the postgres provider could do a BEGIN / UPDATE x where y / ROLLBACK sequence (testing to see if the UPDATE worked but without committing the change), but this would be unique to the postgres provider.

Therefore an architectural approach should be made to this instead of a quick fix.


  • status_id was changed from Feedback to Open

@qgib
Copy link
Contributor Author

qgib commented Mar 21, 2008

Author Name: Jürgen Fischer (@jef-n)


seems this was reintroduced at some point, but:

Editing is not stopped when a commit failure happens and the data is therefore not lost (fixed in c65aee6 (SVN r8211)).

If the commit failure is caused by invalid values (e.g. strings in a numeric column) you can correct them in the attribute table and retry the commit afterwards (fixed in bd9f43f (SVN r8212)).


  • status_id was changed from Open to Closed
  • resolution was changed from to fixed

@qgib
Copy link
Contributor Author

qgib commented Aug 21, 2009

Author Name: Anónimo (Anónimo)


Milestone Version 0.9.2 deleted

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Vectors Related to general vector layer handling (not specific data formats) labels May 24, 2019
@qgib qgib closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Vectors Related to general vector layer handling (not specific data formats)
Projects
None yet
Development

No branches or pull requests

1 participant