Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added log option to histogram operation #929

Merged
merged 3 commits into from
Oct 12, 2016
Merged

Added log option to histogram operation #929

merged 3 commits into from
Oct 12, 2016

Conversation

philippjfr
Copy link
Member

This adds a log option to the histogram operation, which automatically generates logarithmic sampling for the histogram bins. Also includes a small fix to fix bokeh histograms with inverted axes.

@@ -478,6 +478,9 @@ class histogram(ElementOperation):
individually = param.Boolean(default=True, doc="""
Specifies whether the histogram will be rescaled for each Raster in a UniformNdMapping.""")

log = param.Boolean(default=False, doc="""
Whether to apply log scaling """)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would at least mention that it is log10....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, that's what logspace uses, but it should still be explained.

@jlstevens
Copy link
Contributor

Other than a small comment about the docstring, this PR looks fine and I am happy to merge.

@jlstevens
Copy link
Contributor

Other than one unrelated test failure, the tests seem to be ok. Merging.

@jlstevens jlstevens merged commit 68fa72a into master Oct 12, 2016
@philippjfr philippjfr deleted the hist_fixes branch October 14, 2016 01:55
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants