Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard comms fixes #912

Merged
merged 3 commits into from
Oct 7, 2016
Merged

Dashboard comms fixes #912

merged 3 commits into from
Oct 7, 2016

Conversation

philippjfr
Copy link
Member

A fix to get streams working on Jupyter dashboards and another fix to ensure events are processed when an error is received.

@jlstevens
Copy link
Contributor

Great - though I assume we still need to use a dev version of ipywidgets for the dashboard comms to work?

@philippjfr
Copy link
Member Author

Great - though I assume we still need to use a dev version of ipywidgets for the dashboard comms to work?

Yes, I also remembered you have to satisfy the missing jQuery dependency. We'll be able to expose that in the notebook_extension though.

@jlstevens
Copy link
Contributor

Thanks for clarifying. Ready to merge?

@philippjfr
Copy link
Member Author

Yep

@jlstevens jlstevens merged commit 4b4f577 into master Oct 7, 2016
@jbednar jbednar deleted the dashboard_comms_fixes branch October 7, 2016 13:10
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants