-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widgets ignore dimension streams #860
Conversation
@@ -824,6 +832,16 @@ def wrap_tuple_streams(unwrapped, kdims, streams): | |||
return tuple(substituted) | |||
|
|||
|
|||
def drop_streams(streams, keys, kdims): | |||
""" | |||
Drop any dimensionsed streams from the keys and kdims. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in 'dimensioned' and maybe add a line saying what it returns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think it is a little odd to put the keys (typically a very long list) before the kdims (much shorter). The order that feels (slightly) more natural to me for the signature is (streams, kdims, keys)
. As there can be a long list of streams, the next best is probably (kdims, streams, keys)
.
Just a minor point that you may ignore if you wish!
Tests have passed so I will merge it now. I'm excited to try it out! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Widgets now ignore dimensions which are defined through a stream ensuring that only widgets for non-stream dimensions are displayed.