Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of constant dimensions in xarray #817

Merged
merged 1 commit into from
Aug 17, 2016

Conversation

philippjfr
Copy link
Member

This PR fixes handling of constant dimensions in the xarray interface of HoloViews. By default a select operation does not reduce the dimensionality of a HoloViews object, i.e. the dimensionality stays unchanged. Until we have proper support for constant dimensions this is probably the right approach, however xarray does convert coordinates to constant coordinates, which changes the shape of the array. This PR ensures that the shape of the arrays stays unchanged.

@philippjfr philippjfr added in progress type: bug Something isn't correct or isn't working tag: component: data labels Aug 17, 2016
@jlstevens
Copy link
Contributor

Looks ok, but I think we need to have a proper plan regarding constant dimensions across HoloViews. Not sure when we'll find the appropriate time to address that though...

Merging.

@jlstevens jlstevens merged commit 7a3ecd2 into master Aug 17, 2016
@philippjfr philippjfr deleted the xarray_constant_fixes branch September 2, 2016 00:57
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tag: component: data type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants