-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a grid based xarray data interface #713
Conversation
I would be interested in helping you finish off this PR to learn a bit more about xarray. Though there seems to be merge conflicts now? |
I can resolve the merge conflicts now. As for this PR, it might be worth waiting until a multi-dimensional groupby has been merged into xarray (pydata/xarray#818). |
The multi-dimensional groupby was just merged and I think Stephan is targeting an xarray release for next week, so should we try to get this into 1.5.1? |
If the interface is complete and we can support the upcoming xarray release (I suppose we can test against a dev version) then yes, I think it would be good to get in for 1.5.1. |
Sounds good. It would be great to be able to promote this feature at SciPy! |
a1372cf
to
e167810
Compare
Deferring support for aggregate, sample, reduce and reindex. About to add tests and then ready to merge. |
e167810
to
6578401
Compare
As the PR build passed, looks good and I'll merge it now. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
As the title suggests this PR adds an xarray interface, which will allow working with large gridded datasets. It is not quite complete, so should not be merged yet, but it's functional and there are just a few more issues to iron out before I can add unit tests and merge it.
What's still missing?