Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a grid based xarray data interface #713

Merged
merged 11 commits into from
Jul 14, 2016
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 7, 2016

As the title suggests this PR adds an xarray interface, which will allow working with large gridded datasets. It is not quite complete, so should not be merged yet, but it's functional and there are just a few more issues to iron out before I can add unit tests and merge it.

What's still missing?

  • Multi-dimensional aggregate/reduce
  • Add dimension support
  • Reindex support for dropping constant dimensions
  • Unit tests

@jlstevens
Copy link
Contributor

I would be interested in helping you finish off this PR to learn a bit more about xarray. Though there seems to be merge conflicts now?

@philippjfr
Copy link
Member Author

I can resolve the merge conflicts now. As for this PR, it might be worth waiting until a multi-dimensional groupby has been merged into xarray (pydata/xarray#818).

@philippjfr
Copy link
Member Author

The multi-dimensional groupby was just merged and I think Stephan is targeting an xarray release for next week, so should we try to get this into 1.5.1?

@jlstevens
Copy link
Contributor

The multi-dimensional groupby was just merged and I think Stephan is targeting an xarray release for next week, so should we try to get this into 1.5.1?

If the interface is complete and we can support the upcoming xarray release (I suppose we can test against a dev version) then yes, I think it would be good to get in for 1.5.1.

@jbednar
Copy link
Member

jbednar commented Jul 8, 2016

Sounds good. It would be great to be able to promote this feature at SciPy!

@philippjfr
Copy link
Member Author

Deferring support for aggregate, sample, reduce and reindex. About to add tests and then ready to merge.

@jlstevens
Copy link
Contributor

As the PR build passed, looks good and I'll merge it now.

@jlstevens jlstevens merged commit d4250e6 into master Jul 14, 2016
@philippjfr philippjfr deleted the xarray_interface branch September 2, 2016 00:58
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants