Fixed Raster.reduce for non Image types #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might be worth mentioning this in a comment as a reminder. Otherwise looks fine, the pr build is passing and I'm happy to merge. |
|
Not sure it needs a reminder, we will be forced to refactor these methods when they become part of an interface anyway. |
|
Ready to merge, PR build passed. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #595, handles the reduction of the x-axis for the Raster class itself correctly. The reduce method is currently shared between all Raster and Image classes and it only handled the Image case correctly. In future when we have integrated Raster types with the grid interfaces this should be refactored but it works fine for now.