Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plotly 3.8 support #3644

Merged
merged 2 commits into from
Apr 22, 2019
Merged

Plotly 3.8 support #3644

merged 2 commits into from
Apr 22, 2019

Conversation

jonmmease
Copy link
Collaborator

Closes #3643

Two changes:

  • Change plotly.offline.offline.utils to plotly.utils
  • Only add legend options to traces that support them. Plotly.js cleaned up the schema a bit to remove these entries from traces that don't use them, which resulted in some validation errors here.

These changes are backward compatible with plotly.py <3.8 so no need to change version constraints.

@jbednar
Copy link
Member

jbednar commented Apr 22, 2019

Thanks!

@philippjfr philippjfr added this to the v1.12.2 milestone Apr 22, 2019
@philippjfr
Copy link
Member

Looks great, thanks!

@philippjfr philippjfr merged commit 325d03d into master Apr 22, 2019
@philippjfr philippjfr deleted the bug_3643 branch April 29, 2019 11:24
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbednar jbednar jbednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.12.2
Development

Successfully merging this pull request may close these issues.

Support plotly >=3.8.0
3 participants
@jonmmease @jbednar @philippjfr