Allow using apply method with method strings #3554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
apply_method_via_string
branch
from
d7677e9
to
c01f443
Compare
|
@jlstevens Ready to review. |
jlstevens
reviewed
Mar 22, 2019
jlstevens
reviewed
Mar 22, 2019
jlstevens
reviewed
Mar 22, 2019
|
Other than two minor suggestions ( |
philippjfr
force-pushed
the
apply_method_via_string
branch
from
3e9e14d
to
ff3ee9d
Compare
|
Tests are passing now and I'll go ahead and merge. Excited to try it out! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the suggestion outlined in holoviz/datashader#723. This allows the apply method to accept strings which refer to methods on the object, e.g.:
After some discussion @jlstevens and I have decided to make
.applya namespace accessor with the following convenience methods:.apply.opts.apply.select.apply.reduce.apply.aggregateThis also means we can deprecate
HoloMap.reduceandHoloMap.samplewhich are outliers in our API (which are inherited but are not actually usable on DynamicMap) and can be achieved by chaining apply and collapse methods.