Improved attribute handling in Graph.from_networkx #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
the
type: enhancement
philippjfr
force-pushed
the
from_networkx_fixes
branch
from
2194f3f
to
6485c35
Compare
philippjfr
force-pushed
the
from_networkx_fixes
branch
from
af3635d
to
5eb31d7
Compare
|
Merging to make sure the holoviews release is ready in time. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves Graph.from_networkx in a number of ways. First of all it makes sure that non-scalar attributes and indexes (e.g. lists, tuples or dictionaries) do not break the Graph. Secondly this PR will allow passing in a dictionary of node positions which is the canonical way to specify node positions in networkx.