Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign int index of coords if no coords in xarray object #2968

Merged
merged 2 commits into from
Aug 30, 2018

Conversation

jsignell
Copy link
Member

I am not sure exactly how this should work if there is one set of coords specified but not another. But this is a start at least following on the ideas here: #2579 (comment)

@jsignell
Copy link
Member Author

@philippjfr, I think the failure is unrelated?

@philippjfr
Copy link
Member

Looks like minor pyflakes issues:

tests/core/data/testxarrayinterface.py:281:9: F841 local variable 'expected_ys' is assigned to but never used
tests/core/data/testxarrayinterface.py:289:13: F841 local variable 'img' is assigned to but never used

@philippjfr
Copy link
Member

The notebook test failure is indeed just transient though.

@philippjfr
Copy link
Member

Thanks, I'll merge once tests are passing.

@philippjfr philippjfr merged commit 39bdc02 into holoviz:master Aug 30, 2018
@philippjfr
Copy link
Member

Very happy to have another contributor, thanks again!

@jsignell jsignell deleted the assign_coords_if_missing branch August 30, 2018 20:38
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants