-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle zero ranges correctly in regrid operation #2869
Conversation
@stevieb Would you mind testing this? |
c83c36e
to
79c9eba
Compare
@philippjfr that seemed better in that all of the images don't disappear when you zoom in but now there is a new problem. Once the image is entirely out of the viewport it disappears and never comes back. |
Odd, I haven't been able to reproduce that. I'll have another look. |
79c9eba
to
6239007
Compare
Nevermind ran into the issue in a completely separate context and fixed it. Thanks for your help @stevievb. |
517d8f8
to
22e3235
Compare
@jlstevens This is ready to merge once tests pass. |
5bc7e4c
to
94fdd67
Compare
94fdd67
to
6ddd4fc
Compare
Looks good to me. Merging. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
While I fixed the zero range handling in the aggregate operation I seemingly did not do it properly in the regrid operation. Additionally this PR allows Images to contain arrays with a (0, 0) shape, which previously required a hack which would instead store a (1, 1) image.