Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic ScrubberWidget and add throttling #2748

Merged
merged 2 commits into from
May 29, 2018
Merged

Conversation

philippjfr
Copy link
Member

Fixes two issues with the ScrubberWidget:

  1. A few releases ago we added the ability to use the ScrubberWidget on a DynamicMap as long all its dimensions define values, however for this to work the plots had to expand the values into their cross-product. We subsequently reverted the expansion change because it was very slow and expensive for large cross products but did not disable the scrubber. This PR ensures that this works even without expanding the whole cross-product.

  2. This PR adds throttling to the ScrubberWidget by using the same approach used by the selection widgets.

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label May 29, 2018
@philippjfr
Copy link
Member Author

Ready for review and merge.

@jlstevens
Copy link
Contributor

Looks good and I'm glad the most tricky it is contained within a well-defined utility. I'll merge once the pr build goes green too.

@jlstevens
Copy link
Contributor

The failing pr test was a transient (now restarted). Merging.

@jlstevens jlstevens merged commit bea39dc into master May 29, 2018
@philippjfr philippjfr deleted the scrubber_throttling branch July 4, 2018 11:13
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants