Allow the conversion interface to discover pandas indexes #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
tag: component: data
type: enhancement
philippjfr
force-pushed
the
pandas_conversion_index
branch
from
8a158bb
to
a87257e
Compare
philippjfr
changed the title
philippjfr
changed the title
|
Ready to merge. |
jlstevens
reviewed
May 28, 2018
| for d in vdims] | ||
| selected = self._element.clone(kdims=ds_kdims, vdims=ds_vdims) | ||
| else: | ||
| selected = self._element.reindex(groupby+kdims, vdims) |
There was a problem hiding this comment.
Is the same logic used elsewhere in a context other than the conversion interface? Is any code shared and is it worth abstracting out?
There was a problem hiding this comment.
No, I cannot think of anywhere this could be reused atm.
|
Other than one question in the comment above, this looks fine and I'm happy to merge once you respond. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows referencing pandas indexes in .to interface even when Dataset does not declare them as dimensions.