Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled auto-indexable on Dataset baseclass #2522

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Conversation

philippjfr
Copy link
Member

A while back it seem I accidentally enabled auto-indexing for the Dataset baseclass. The feature was meant as a convenience for 1D Chart types but absolutely should not apply to the baseclass which should accurately represent the underlying data and not fiddle with it. This needs to be called out explicitly in the release notes but should be done immediately since it is a bug and can make it awkward to work with Graph types which allow passing in a list or array of node indices to define an explicit order. This currently will not work correctly because it will add an index automatically.

  • Updated existing tests

@philippjfr
Copy link
Member Author

Ready to merge.

@jlstevens
Copy link
Contributor

Looks good. I assume you checked _auto_indexable_1d attribute has the right boolean state everywhere it needs it.

Merging.

@jlstevens jlstevens merged commit b8b9441 into master Apr 4, 2018
@philippjfr philippjfr deleted the dataset_autoindex branch July 4, 2018 11:15
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants