HTML fix in logo for export #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the new one much better! |
|
I'm happy with it too, I'll go ahead and merge. |
ea42gh
pushed a commit
to ea42gh/holoviews
that referenced
this pull request
Aug 12, 2017
* Removed inner divs in logo to fix export * Removed vertical-align style as it has no effect
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to address #1769. The current commit (removing inner divs) fixes the export. The problem is that the logos now look like this:
As opposed to the previous arrangement that was:
With all three logos, it now looks like:
Which I don't quite like as much but either way, fixing the export is far more important than the arrangement of the logos!