Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opts in doc 2 #1763

Merged
merged 2 commits into from
Jul 27, 2017
Merged

Add opts in doc 2 #1763

merged 2 commits into from
Jul 27, 2017

Conversation

jordansamuels
Copy link
Contributor

Cleaner version of #1760, which inadvertently picked up #1759 during a rebase.

Jordan Samuels added 2 commits July 27, 2017 08:48
* Complements holoviz#1759
* Execute `git grep -lE '\)\((style|plot|norm)=' -- examples | xargs  perl -pi -e 's/\)\((style|plot|norm)=/).opts($1=/g'`
* Spot check notebooks
* Manually search `git grep ')(' -- examples | grep -vE '.{255}'
* Fix cases by hand
`
@jlstevens
Copy link
Contributor

Having skimmed the diff, all the changes look correct to me. As the tests are green, I think it is better to merge sooner than later. I'm sure there will be other places that __call__ need to be replaced but having this merged will make those other instances easier to find.

@jordansamuels Thanks again for this PR! Merging.

@jlstevens jlstevens merged commit 350b323 into holoviz:master Jul 27, 2017
@jlstevens jlstevens added this to the 1.8.2 milestone Aug 21, 2017
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants