Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SpikesPlot color index to None by default #1671

Merged
merged 5 commits into from
Jul 7, 2017

Conversation

jlstevens
Copy link
Contributor

Before:

After:

I think this is a bug fix, not a style change as before a vdim was being mapped to both height and color when it should only be mapped to height.

@jlstevens jlstevens added this to the v1.8.1 milestone Jul 2, 2017
@jlstevens
Copy link
Contributor Author

Test data will need update. Also should mention this PR addresses #1669.

@jlstevens
Copy link
Contributor Author

I'll update the colormap to 'fire' before updating the display data though...

@jlstevens
Copy link
Contributor Author

@philippjfr pr builds are finally green. Ready to merge.

@philippjfr philippjfr merged commit 82c9e17 into master Jul 7, 2017
@philippjfr philippjfr deleted the spike_color_index_fix branch July 31, 2017 22:57
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants